Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Since version 0.0.12a26, settings are not reloaded with my skill #91

Closed
goldyfruit opened this issue May 19, 2023 · 3 comments · Fixed by #116
Closed

Since version 0.0.12a26, settings are not reloaded with my skill #91

goldyfruit opened this issue May 19, 2023 · 3 comments · Fixed by #116

Comments

@goldyfruit
Copy link
Member

goldyfruit commented May 19, 2023 •
edited
Loading

Before version 0.0.12a26, if I changed the content of settings.json, it got detected and the skill reloads the settings.

Since version 0.0.12a26 (this change 70bc851), any changes in settings.json are not detected anymore.

Here is the skill https://github.com/smartgic/skill-sonos-controller/blob/21.2.1.1/__init__.py#L372-L390
@goldyfruit
Copy link
Member Author

goldyfruit commented Jun 6, 2023 •
edited
Loading

Just did few more test with fresh build and I'm still able to validate that version 0.0.12a25 get the changes but not versions above.

@goldyfruit
Copy link
Member Author

I'm wondering if its not related to the __init__() method.

@emphasize
Copy link
Member

Doesn't help much, but SkillSettingsTests should be written

Lets work backwards from how settings.json is monitored

NeonDaniel added a commit that referenced this issue Jul 12, 2023
@NeonDaniel
Add locking around skill settings changes
759ec42 
Add test case to reproduce/resolve #93
Possibly related to #91
@NeonDaniel NeonDaniel mentioned this issue Jul 12, 2023
Merged
NeonDaniel added a commit that referenced this issue Jul 12, 2023
@NeonDaniel
Refactor _handle_settings_file_change to ignore non-settings file c…
e3d4796 
…hanges

Add unit tests for settings filewatcher and file change callback
Potentially closes #91
@NeonDaniel NeonDaniel mentioned this issue Jul 12, 2023
Merged
@github-actions github-actions bot mentioned this issue Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unit tests and improvements to settings change callback OpenVoiceOS/OVOS-workshop
2 participants
@goldyfruit @emphasize