Skip to content

Commit

Permalink
move methods around
Browse files Browse the repository at this point in the history
  • Loading branch information
JarbasAl committed Sep 6, 2023
1 parent 90b17ef commit 83e14c5
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 13 deletions.
13 changes: 0 additions & 13 deletions ovos_workshop/skills/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -1878,19 +1878,6 @@ def speak_dialog(self, key: str, data: Optional[dict] = None,
)
self.speak(key, expect_response, wait, {})

@staticmethod
def acknowledge():
"""
Acknowledge a successful request.
This method plays a sound to acknowledge a request that does not
require a verbal response. This is intended to provide simple feedback
to the user that their request was handled successfully.
"""
# DEPRECATED - note that this is a staticmethod and uses the old endpoint
# the OVOSSkill class does things properly
return play_acknowledge_sound()

# method named init_dialog in mycroft-core
def load_dialog_files(self, root_directory: Optional[str] = None):
"""
Expand Down
14 changes: 14 additions & 0 deletions ovos_workshop/skills/mycroft_skill.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
from ovos_bus_client import MessageBusClient, Message
from ovos_utils.log import LOG, log_deprecation
from ovos_workshop.skills.base import BaseSkill, is_classic_core
from ovos_utils.sound import play_acknowledge_sound


class _SkillMetaclass(ABCMeta):
Expand Down Expand Up @@ -163,6 +164,19 @@ def _init_settings_manager(self):
except ImportError:
pass # standalone skill, skip backwards compat property

@staticmethod
def acknowledge():
"""
Acknowledge a successful request.
This method plays a sound to acknowledge a request that does not
require a verbal response. This is intended to provide simple feedback
to the user that their request was handled successfully.
"""
# DEPRECATED - note that this is a staticmethod and uses the old endpoint
# the OVOSSkill class does things properly
return play_acknowledge_sound()

def _init_settings(self):
"""Setup skill settings."""
if is_classic_core():
Expand Down

0 comments on commit 83e14c5

Please sign in to comment.