Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial new user propagation #1939

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Conversation

Martii
Copy link
Member

@Martii Martii commented Jan 14, 2022

@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jan 14, 2022
@Martii Martii merged commit 2dca71f into OpenUserJS:master Jan 14, 2022
@Martii Martii deleted the evenMoreRework branch January 14, 2022 15:08
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Jan 15, 2022
OpenUserJS#1939 OpenUserJS#1938 OpenUserJS#1937 OpenUserJS#1446 OpenUserJS#1470 ... OpenUserJS#944

NOTE(s):
* Camelcaps not adhered to on some... may revisit.
* `userrole` isn't consistent with `roleName` however is consistent with other objects... may revisit.
* May not be the most efficient with `parseUser` but other option is to pull in `userRoles.json` and enumerate grab... may revisit.
* Will have to boot everyone off temporarily to propagate values to sessions.
Martii added a commit that referenced this pull request Jan 15, 2022
#1939 #1938 #1937 #1446 #1470 ... #944

NOTE(s):
* Camelcaps not adhered to on some... may revisit.
* `userrole` isn't consistent with `roleName` however is consistent with other objects... may revisit.
* May not be the most efficient with `parseUser` but other option is to pull in `userRoles.json` and enumerate grab... may revisit.
* Will have to boot everyone off temporarily to propagate values to sessions.

Auto-merge
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.
Development

Successfully merging this pull request may close these issues.

1 participant