Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ease some caps and limits for privileged authed #1913

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Ease some caps and limits for privileged authed #1913

merged 1 commit into from
Dec 30, 2021

Conversation

Martii
Copy link
Member

@Martii Martii commented Dec 30, 2021

  • Mod's need more access (less cap limiting) and of course Admin+.
  • Rate limiting is in effect for Mods in case their device or network is compromised. May consider a "pardon" like with scoring when that time comes.

Applies to #944

NOTE:

  • This is a WIP. Ton of things to test and (re)consider. Patience is a virtue. ;) :)

@Martii
Ease some caps and limits for privileged authed
413b901 
* Mod's need more access *(less cap limiting)* and of course Admin+.
* Rate limiting is in effect for Mods in case their device or network is compromised. May consider a "pardon" like with scoring when that time comes.

Applies to OpenUserJS#944

NOTE:
* This is a WIP. Ton of things to test and (re)consider. Patience is a virtue. ;) :)
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. security Usually relates to something critical. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Dec 30, 2021
@Martii Martii merged commit 9fcc394 into OpenUserJS:master Dec 30, 2021
@Martii Martii deleted the Issue-944easeCapsAndLimitsForAuthedPrivileged branch December 30, 2021 10:47
@Martii
Copy link
Member Author

Martii commented Jan 3, 2022

@jesus2099

What also does this commit summary say to you?

This is also in reference to the assumption you put on production.

@jesus2099
Copy link

Is it also about the captcha problem I got when trying to edit my profile a second time? https://openuserjs.org/discuss/Edit_Profile_Captcha_is_broken_429_Too_Many_Requests

@Martii
Copy link
Member Author

Martii commented Jan 3, 2022

@jesus2099

Is it also about the captcha problem I got when trying to edit my profile a second time?

Yes. Look at the actual commit message fourth here where it says:

"This is a WIP. Ton of things to test and (re)consider. Patience is a virtue. ;) :)"

In short, outside of the teaching exercise for you, things are changing to combat some bad actors trying to take the site down. Things will definitely be in flux for some time and I only have so much energy and time at the moment to implement it all. We are also in lockdown which is a feature that has been around since 2014 to keep the site up. Unless you have a reason to take the site down these caps and limitations will stay in effect until the threat is over. I hope you understand a little more about this. I always do my best to document the commit history in as plain, and clear, as I can get put it at the time. :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. security Usually relates to something critical.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Martii @jesus2099