Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase poolSize depending on multiplier #1552

Merged
merged 3 commits into from
Dec 19, 2018
Merged

Increase poolSize depending on multiplier #1552

merged 3 commits into from
Dec 19, 2018

Conversation

Martii
Copy link
Member

@Martii Martii commented Dec 19, 2018

  • This didn't seem to help in a direct test on production but doing since it's the logical thing to do with our current process manager.

NOTE(S):

  • We don't currently have clustering management in the project itself but may at some point in the future so this could eventually use some improvement. Trying to keep this simple at start for everyone.

Applies to #1548

@Martii
Increase poolSize depending on expected pro static thread count
89b17ca 
* This didn't seem to help in a direct test on production but doing since it's the logical thing to do with our current process manager.

NOTE(S):
* We don't currently have clustering management in the project itself but may at some point in the future so this could eventually use some improvement. Trying to keep this simple at start for everyone.


Applies to OpenUserJS#1548
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. dependency issue Hmmph! A dependency issue labels Dec 19, 2018
@Martii
Go back to the original multiplier
03e9dd3 
* This value is per thread otherwise it would be huge in each thread. Durr.

Applies to OpenUserJS#1548
@Martii
Try triple multiplier
a4509b0 
* Since commit notes said it didn't seem to help let's try tripling the multiplier

Applies to OpenUserJS#1548
@Martii Martii changed the title Increase poolSize depending on expected pro static thread count Increase poolSize depending on multiplier Dec 19, 2018
@Martii Martii merged commit 544c9fb into OpenUserJS:master Dec 19, 2018
@Martii Martii deleted the Issue-1548poolSize branch December 19, 2018 02:39
@Martii
Copy link
Member Author

Martii commented Dec 19, 2018 •
edited
Loading

NOTE: Worked for a little bit but then resumed lagging... might be an improvement IDK yet.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. dependency issue Hmmph! A dependency issue enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii