Restore some of the @icon checks until resolved
#1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do some of the checks that don't pertain to TLS issue
* Fix with additional `on('error',...` for the request instead of response. My bad although still doesn't appear to work with native `https.get` and `https.request`.
Applies to OpenUserJS#1323
Martii
added
bug
|
Deployed. |
Martii
commented
Feb 10, 2018
| } else { | ||
| fn = /^http:/.test(icon) ? http : https; | ||
|
|
||
| // Workaround for #1323 |
There was a problem hiding this comment.
Skipping https here until resolved.
Martii
commented
Feb 10, 2018
| }).on('error', function (aErr) { | ||
| aInnerCallback(aErr); | ||
| }); | ||
| }).on('error', function (aErr) { |
There was a problem hiding this comment.
Added missing request error trap here.
Martii
commented
Feb 10, 2018
| } else { | ||
| aInnerCallback(null); | ||
| } | ||
| }).on('error', function (aErr) { |
There was a problem hiding this comment.
Initial error trap was on response and not the request... still present.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on('error',...for the request instead of response. My bad although still doesn't appear to work with nativehttps.getandhttps.request.Applies to #1323