Subclass the Error object
#1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Some reworking of graceful failures to indicate what they are * This probably should have been done around the time `statusCodePage` was implemented with ES5 compatible inheritance. May move this routine to debug.js * One comment BUG fixed * These trapped errors are `throw`able if we choose NOTES: * Almost named the inherited `Error` Object as `userError` since that's what most of these end up being. ;) * **NOT** tested yet with the webhook... have to merge first. GitHub doesn't seem to show the statusMessage so might be out of luck here. 400 is User Error 500 is Server Error *(usually... have a few Watchpoints to figure out if they are the correct code)* * This is pass number 1 ... optimizing/tweaking will come later after this testing and additional respite... including some possible status code changes Applies to OpenUserJS#37
Martii
added
bug
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Nov 28, 2017
* Some Code condensing in the process as a result NOTES: * Some of the errors returned may still be strings instead of an Error *(subclassed or not)* so add default conditional for that. Usually those are 400 user errors but could be 500 server error... unknown at this time. Post OpenUserJS#1284 OpenUserJS#1289 and OpenUserJS#1274 OpenUserJS#37
Martii
added a commit
that referenced
this pull request
Nov 28, 2017
* Some Code condensing in the process as a result NOTES: * Some of the errors returned may still be strings instead of an Error *(subclassed or not)* so add default conditional for that. Usually those are 400 user errors but could be 500 server error... unknown at this time. Post #1284 #1289 and #1274 #37 Auto-merge
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Dec 5, 2017
* Bug fix on helper * Automate rejection of an occasional issue with excessive dimensions Post OpenUserJS#1283 OpenUserJS#1274
Martii
added a commit
that referenced
this pull request
Dec 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
statusCodePagewas implemented with ES5 compatible inheritance. May move this routine to debug.jsthrowable if we chooseNOTES:
ErrorObject asuserErrorsince that's what most of these end up being. ;)Applies to #37