Skip to content

Commit

Permalink
Resuspend http @icon check (#1327)
Browse files Browse the repository at this point in the history
* Bogus domain causes untrapped `RangeError [ERR_HTTP_INVALID_STATUS_CODE]: Invalid status code: ENOTFOUND`

Applies to #1323

Auto-merge
  • Loading branch information
Martii authored Feb 10, 2018
1 parent c488785 commit 38a7610
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions controllers/scriptStorage.js
Original file line number Diff line number Diff line change
Expand Up @@ -1467,10 +1467,8 @@ exports.storeScript = function (aUser, aMeta, aBuf, aUpdate, aCallback) {
fn = /^http:/.test(icon) ? http : https;

// Workaround for #1323
if (fn === https) {
aInnerCallback(null); // NOTE: Suspend further checks
return;
}
aInnerCallback(null); // NOTE: Suspend further checks
return;
// /Workaround for #1323

fn.get(URL.parse(icon), function (aRes) {
Expand Down

0 comments on commit 38a7610

Please sign in to comment.