Feature/6491 display the number of tracks that need to be validated according to the svz metric #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted according to SVZ metric
Updated the quantile calculation to use the "higher" interpolation method for more accurate results in the percentile computation. This change ensures that the computed percentile values are consistently derived from the higher range of the data set.
Introduce unit tests for three calculation strategies: DetectionRateByPercentile, DetectionRateByMaxConfidence, and DetectionRateByLength. Validate their accuracy using fixtures and expected results for different track datasets.
Renamed fixtures with 'given_' prefix to clarify their role as setup data providers. Added validation to ensure the `detection_rate_strategy` uses the correct DataFrame by implementing the `assert_strategy_called_with_tracks_assigned_to_flows` method. This enhances test reliability and readability.
Introduced the `TracksAsDataFrameProvider` class to encapsulate track data provisioning logic. Updated the SVZ number of tracks calculation code and related tests to use the new provider. This change improves modularity and separation of concerns in the data handling process.
Added new labels to display the number of tracks to be validated in the track statistics frame. Updated the widget placement and the label text configuration to reflect the track count dynamically.
…at-need-to-be-validated-according-to-the-svz-metric
briemla
requested changes
Nov 21, 2024
tests/OTAnalytics/plugin_number_of_tracks_to_be_validated/conftest.py
Outdated
Show resolved
Hide resolved
OTAnalytics/plugin_number_of_tracks_to_be_validated/svz/metric_rates.py
Outdated
Show resolved
Hide resolved
...alytics/plugin_number_of_tracks_to_be_validated/svz/test_number_of_tracks_to_be_validated.py
Show resolved
Hide resolved
OTAnalytics/plugin_number_of_tracks_to_be_validated/svz/number_of_tracks_to_be_validated.py
Outdated
Show resolved
Hide resolved
OTAnalytics/plugin_number_of_tracks_to_be_validated/svz/number_of_tracks_to_be_validated.py
Outdated
Show resolved
Hide resolved
Replaced hardcoded 'manual_classification' with a constant MANUAL_CLASSIFICATION. This enhances code readability and maintainability by avoiding magic strings.
Centralize the SVZ_RATE constant and update its usage across the codebase to improve code readability and maintainability. This ensures consistency and simplifies future updates related to the SVZ rate.
Previously hardcoded percentile value is now defined as a constant. This improves maintainability by centralizing the value, making changes easier in the future.
Ensure that the tracks provider's provide method is called exactly once in the test_number_of_tracks_to_be_validated case. This change enhances the test coverage by verifying interactions with the tracks provider mock.
Updated the track fixture name from `track_one_false_detection_class` to `track_two_false_detection_classes` across multiple test files for clarity and better alignment with the dataset content. This modification enhances code readability and accuracy regarding the track classifications used in the tests.
Replaced "Gruppe A3" with "svz-rate" to standardize the naming convention. This change enhances readability and consistency across the codebase.
briemla
approved these changes
Nov 22, 2024
briemla
deleted the
feature/6491-display-the-number-of-tracks-that-need-to-be-validated-according-to-the-svz-metric
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OP#6491