Task/5990 show track statistics #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schubsen
requested review from
briemla and
randy-seng
and removed request for
randy-seng
briemla
requested changes
Oct 14, 2024
schubsen
changed the title
schubsen
changed the title
…bles before using them
…ficCam/OTAnalytics into task/5990-show-track-statistics
…ing section exists
briemla
requested changes
Oct 18, 2024
Previously, the function assumed a single offset for all cutting sections, which could lead to inaccuracies. The new implementation processes each cutting section individually, updating results iteratively, ensuring precise track containment evaluation.
Remove redundant instance checks and replace direct attribute access with property decorators in `dummy_viewmodel.py`. This simplifies the code and ensures that missing instances are properly handled through `MissingInjectedInstanceError` exceptions raised within the property methods.
Removed unnecessary parentheses in the return statement of the _to_coordinate_tuple method. This change makes the code more Pythonic and slightly improves readability.
…ui elements to one frame and make that frame scrollable
|
@briemla I put the track statistics, visualization filters, and video control UI elements to a scrollable frame. |
briemla
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OP#5990