Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/4710-bbox-in-miovision-videos-are-completly-out-of-sync-with-background-frame #514

Conversation

briemla
Copy link
Contributor

@briemla briemla commented Apr 30, 2024

OP#4710
OP#5021

@briemla briemla requested a review from randy-seng April 30, 2024 14:07
Copy link
Member

@randy-seng randy-seng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I found some print statements. Should we log them?

Copy link
Member

@randy-seng randy-seng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one more question~

briemla added 2 commits May 7, 2024 15:06
…s-are-completly-out-of-sync-with-background-frame' into bug/4710-bbox-in-miovision-videos-are-completly-out-of-sync-with-background-frame
@randy-seng randy-seng requested review from randy-seng and removed request for randy-seng May 7, 2024 13:10
randy-seng
randy-seng previously approved these changes May 7, 2024
@randy-seng randy-seng enabled auto-merge May 7, 2024 13:10
@briemla briemla disabled auto-merge May 7, 2024 13:45
@briemla briemla requested a review from randy-seng May 7, 2024 14:20
@briemla briemla enabled auto-merge May 7, 2024 19:35
@randy-seng randy-seng requested review from randy-seng and removed request for randy-seng May 8, 2024 07:31
@briemla briemla merged commit 6e7f254 into main May 8, 2024
7 checks passed
@briemla briemla deleted the bug/4710-bbox-in-miovision-videos-are-completly-out-of-sync-with-background-frame branch May 8, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants