Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/4735-event-file-is-bigger-after-updating-event-creation #490

Merged
merged 4 commits into from
Mar 27, 2024
Merged

bug/4735-event-file-is-bigger-after-updating-event-creation #490

merged 4 commits into from
Mar 27, 2024

Conversation

briemla
Copy link
Contributor

@briemla briemla commented Mar 26, 2024

OP#4735

@briemla briemla requested a review from randy-seng March 26, 2024 15:10
randy-seng
randy-seng reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@randy-seng randy-seng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event creation has slowed down, I added some changes to speed up removing duplicate events from the event repository. It should be faster now. The benchmark is also running as of writing this comment. @briemla Can you review my changes. I'll approve this PR when I get your ok.

@randy-seng randy-seng assigned briemla and unassigned randy-seng Mar 27, 2024
@briemla
Copy link
Contributor Author

briemla commented Mar 27, 2024 •
edited
Loading

The event creation has slowed down, I added some changes to speed up removing duplicate events from the event repository. It should be faster now. The benchmark is also running as of writing this comment. @briemla Can you review my changes. I'll approve this PR when I get your ok.

Looks good to me. I switched the invocation order in add. Duplicates will now be discarded before sorting as it already was done in add_all. This is to be consistent between the two add-methods.
@randy-seng it is ready to be merged from my side.

@randy-seng randy-seng self-requested a review March 27, 2024 17:07
@randy-seng randy-seng merged commit affd88c into main Mar 27, 2024
5 checks passed
@randy-seng randy-seng deleted the bug/4735-event-file-is-bigger-after-updating-event-creation branch March 27, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randy-seng randy-seng randy-seng approved these changes

Assignees

@briemla briemla

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briemla @randy-seng