bug/4709-activation-of-filter-by-date-is-broken #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randy-seng
requested changes
Mar 21, 2024
…enabling of datetime filter on deactivating class filter
randy-seng
previously approved these changes
Mar 25, 2024
randy-seng
dismissed
their stale review
Forgot to add comment of changes I've done
randy-seng
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Looks good! I have fixed the failed unit tests. Also the DefaultFilterRange wasn't set when switching to the next event at the first occasion. I have reassigned this PR to you so that you can have a look at my changes. You can go ahead and merge if everything is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OP#4709