Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/3027-get-metadata-for-tracks-in-trackdataset #428

Merged
merged 18 commits into from
Jan 23, 2024
Merged

feature/3027-get-metadata-for-tracks-in-trackdataset #428

merged 18 commits into from
Jan 23, 2024

Conversation

randy-seng
Copy link
Member

@randy-seng randy-seng commented Jan 11, 2024 •
edited
Loading

OP#3027
OP#4063

@randy-seng
Define properties first and last track occurrence in TrackDataset
6a351ed
@randy-seng
Implement first and last occurrence properties for PythonTrackDataset
7ddd581
@randy-seng
Return None if TrackDataset is empty for first and last occurrence
4b4dfad
@randy-seng
Implement first and last occurrence for PandasTrackDataset
8f3557c
@randy-seng
Reorder methods
44bd0e1
@randy-seng
Define property classifications for TrackDataset
759ffca
@randy-seng
Add unit tests for classifications property of TrackDataset
31e33d9
@randy-seng
Implement property classifications for TrackDataset
2ca3dde
@randy-seng
Extend TrackRepository with new properties
1ece2b0
@randy-seng
Use classification property of TrackRepository in TracksMetadata
13ac5cc
@randy-seng
Use first and last occurrence properties of TrackRepository in Tracks…
dc54d87 
…Metadata
@randy-seng
Fix selecting wrong property for last occurrence in TrackRepository
d86610a
@randy-seng
Add unit test for classification property in TrackRepository
32db591
@randy-seng
Fix typo
27ffe21
@randy-seng
Clean up documentation
f06e741
@randy-seng
Use track properties
f09af72
@randy-seng randy-seng requested a review from briemla January 11, 2024 14:53
@randy-seng randy-seng marked this pull request as ready for review January 11, 2024 14:53
briemla
briemla approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@briemla briemla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@briemla briemla merged commit 212a2a0 into main Jan 23, 2024
5 checks passed
@briemla briemla deleted the feature/3027-get-metadata-for-tracks-in-trackdataset branch January 23, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briemla briemla briemla approved these changes

Assignees

@briemla briemla

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randy-seng @briemla