Feature/2485 reimplement intersection strategy for sections and flows #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sections and intersection points of tracks and sections
…gy-for-sections-and-flows
…tes contained by sections This method will be required when trying to create intersection events with area sections.
…tes contained by sections This method will be required when trying to create intersection events with area sections.
…ction-strategy-for-sections-and-flows' into feature/2485-reimplement-intersection-strategy-for-sections-and-flows
The track id column is now used as the DataFrame index. Thus, there is no column for track ids anymore.
Use DataFrame index to access track ids.
… as factory method
… representation of PygeosTrackGeometryDataset
…gy-for-sections-and-flows
briemla
previously approved these changes
Dec 21, 2023
briemla
previously approved these changes
Dec 21, 2023
briemla
reviewed
Jan 10, 2024
randy-seng
commented
Jan 10, 2024
There was a problem hiding this comment.
@briemla I reviewed your changes! Looks good to me. I also renamed a test class and removed a resolved todo comment.
briemla
approved these changes
Jan 10, 2024
briemla
deleted the
feature/2485-reimplement-intersection-strategy-for-sections-and-flows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OP#2485
OP#3586
OP#3695