Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/3670-background-image-is-not-updated-when-video-is-added #411

Merged

Conversation

briemla
Copy link
Contributor

@briemla briemla commented Nov 21, 2023

OP#3670

Copy link
Member

@randy-seng randy-seng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But shouldn't we delete the old TrackBackgroundPlotter in OTAnalytics.plugin_ui.visualization including all related tests?

@randy-seng randy-seng assigned briemla and unassigned randy-seng Nov 23, 2023
@briemla briemla requested a review from randy-seng November 24, 2023 11:58
@randy-seng randy-seng assigned randy-seng and unassigned briemla Nov 27, 2023
@randy-seng randy-seng merged commit 65451c0 into main Nov 27, 2023
@randy-seng randy-seng deleted the bug/3670-background-image-is-not-updated-when-video-is-added branch November 27, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants