Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/3419-remove-only-events-of-changed-or-deleted-sections #383

Merged

Conversation

briemla
Copy link
Contributor

@briemla briemla commented Oct 28, 2023

OP#3419

Copy link
Member

@randy-seng randy-seng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just one question.

I also extended some test cases and fixed a bug where clearing the EventRepository did not reset the internal storage for non-section events.

@randy-seng randy-seng assigned briemla and unassigned randy-seng Nov 6, 2023
@briemla briemla requested a review from randy-seng November 21, 2023 14:29
…nly-events-of-changed-or-deleted-sections

# Conflicts:
#	OTAnalytics/application/use_cases/event_repository.py
#	tests/OTAnalytics/domain/test_event.py
@randy-seng randy-seng self-assigned this Nov 23, 2023
@randy-seng randy-seng merged commit c2ec46b into main Nov 23, 2023
@randy-seng randy-seng deleted the feature/3419-remove-only-events-of-changed-or-deleted-sections branch November 23, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants