Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3266 calculate geometry once per used offset group section by offset before creating intersection objects #380

Conversation

randy-seng
Copy link
Member

OP#3266

…speed up

- Sections are now grouped by their offset to calculate track geometries
only once with the respective group offset.
- The IntersectParallelizationStrategies execute method has been
changed to accept a tuple of arguments (Tracks, Sections, the Group Offset)
to be passed to the intersection function
- The abstract classes LineIntersector and AreaIntersector and their
implementations have been removed and replaced by
use their equivalent shapely implementations
…d-offset-group-section-by-offset-before-creating-intersection-objects
@randy-seng randy-seng requested a review from briemla October 23, 2023 18:13
@randy-seng randy-seng marked this pull request as ready for review October 23, 2023 18:13
@randy-seng randy-seng marked this pull request as draft October 24, 2023 13:35
@randy-seng randy-seng assigned randy-seng and unassigned briemla Oct 24, 2023
@randy-seng randy-seng marked this pull request as ready for review October 30, 2023 16:58
randy-seng and others added 4 commits November 2, 2023 14:10
…d-offset-group-section-by-offset-before-creating-intersection-objects
…once-per-used-offset-group-section-by-offset-before-creating-intersection-objects' into feature/3266-calculate-geometry-once-per-used-offset-group-section-by-offset-before-creating-intersection-objects
Copy link
Contributor

@briemla briemla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice so far. Just a few comments. I fixed some smaller things.

briemla and others added 3 commits November 8, 2023 17:36
…d-offset-group-section-by-offset-before-creating-intersection-objects
…d-offset-group-section-by-offset-before-creating-intersection-objects
…d-offset-group-section-by-offset-before-creating-intersection-objects
@randy-seng randy-seng merged commit 9659788 into main Nov 9, 2023
@randy-seng randy-seng deleted the feature/3266-calculate-geometry-once-per-used-offset-group-section-by-offset-before-creating-intersection-objects branch November 9, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants