Feature/2972 extract track storage into plugin layer #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create Python and Pandas implementations
randy-seng
requested changes
Sep 22, 2023
There was a problem hiding this comment.
Looks good overall! I have some questions though~
Also, the test workflow on windows failed during the installtion of python dependencies. Apparently installing functiontrace errors on windows. And I also found a bug when using cutting section. There is some problem with the type of variable when trying to display the information popup after a cut.
Use docstrings already defined by abstract class
randy-seng
approved these changes
Sep 26, 2023
randy-seng
deleted the
feature/2972-extract-track-storage-into-plugin-layer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OP#2972