Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use max class of tracks instead of detection classes for classification filter #233

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Use max class of tracks instead of detection classes for classification filter #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67585fc
Use max class of tracks instead of detection classes for classificati…
randy-seng Jun 19, 2023
587b713
Merge branch 'main' into bug/2328-use-max_class-of-tracks-instead-of-…
briemla Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions OTAnalytics/application/state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,8 +463,7 @@ def _update_classifications(self, new_tracks: list[TrackId]) -> None:

for track_id in new_tracks:
if track := self._track_repository.get_for(track_id):
for detections in track.detections:
updated_classifications.add(detections.classification)
updated_classifications.add(track.classification)
self._classifications.set(updated_classifications)

def _get_all_track_detections(self) -> Iterable[Detection]:
Expand Down
11 changes: 2 additions & 9 deletions tests/OTAnalytics/application/test_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,20 +247,13 @@ def test_update_classifications(self, track: Mock) -> None:

tracks_metadata._update_classifications([track.id])

assert tracks_metadata.classifications == {"car", "truck"}
assert tracks_metadata.classifications == {"car"}
mock_track_repository.get_for.assert_any_call(track.id)
assert mock_track_repository.get_for.call_count == 1

track.detections[0].classification = "bicycle"
tracks_metadata._update_classifications([track.id])

assert tracks_metadata.classifications == {"car", "truck", "bicycle"}
assert tracks_metadata.classifications == {"car"}
mock_track_repository.get_for.assert_any_call(track.id)
assert mock_track_repository.get_for.call_count == 2

track.detections[0].classification = "car"
tracks_metadata._update_classifications([track.id])

assert tracks_metadata.classifications == {"car", "truck", "bicycle"}
mock_track_repository.get_for.assert_any_call(track.id)
assert mock_track_repository.get_for.call_count == 3