Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let line sections be defined by a list of multiple coordinates #176

Merged
merged 5 commits into from
May 3, 2023
Merged

Let line sections be defined by a list of multiple coordinates #176

merged 5 commits into from
May 3, 2023

Conversation

randy-seng
Copy link
Member

OP#2064

@randy-seng randy-seng requested a review from briemla May 1, 2023 23:50
@randy-seng randy-seng marked this pull request as ready for review May 1, 2023 23:51
briemla and others added 3 commits May 2, 2023 10:33
briemla
briemla requested changes May 3, 2023
View reviewed changes
Copy link
Contributor

@briemla briemla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. The section files in tests/data and in data need to be converted. At the moment, only one otflow file is converted.

briemla
briemla previously approved these changes May 3, 2023
View reviewed changes
@briemla briemla assigned randy-seng and unassigned briemla May 3, 2023
@randy-seng randy-seng requested a review from briemla May 3, 2023 09:52
@randy-seng randy-seng merged commit 8dd50d2 into main May 3, 2023
@randy-seng randy-seng deleted the user-story/2064-let-line-section-be-defined-by-a-list-of-multiple-coordinates branch May 3, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briemla briemla briemla approved these changes

Assignees

@randy-seng randy-seng

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randy-seng @briemla