Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve new type discussion template #45

Merged
merged 11 commits into from
Jul 9, 2024

Conversation

clementbiron
Copy link
Member

Improve the template to create a discussion for adding new terms type. This can be tested on my fork here.

You can see an example of the result of the discussion opened with this template at this address.

@clementbiron clementbiron requested a review from MattiSG June 27, 2024 14:05
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better choice for the example with WhatsApp, congrats! 👍

.github/DISCUSSION_TEMPLATE/new-type.yml Outdated Show resolved Hide resolved
.github/DISCUSSION_TEMPLATE/new-type.yml Outdated Show resolved Hide resolved
.github/DISCUSSION_TEMPLATE/new-type.yml Outdated Show resolved Hide resolved
.github/DISCUSSION_TEMPLATE/new-type.yml Outdated Show resolved Hide resolved
.github/DISCUSSION_TEMPLATE/new-type.yml Outdated Show resolved Hide resolved
.github/DISCUSSION_TEMPLATE/new-type.yml Outdated Show resolved Hide resolved
.github/DISCUSSION_TEMPLATE/new-type.yml Outdated Show resolved Hide resolved
.github/DISCUSSION_TEMPLATE/new-type.yml Outdated Show resolved Hide resolved
.github/DISCUSSION_TEMPLATE/new-type.yml Outdated Show resolved Hide resolved
.github/DISCUSSION_TEMPLATE/new-type.yml Outdated Show resolved Hide resolved
@MattiSG
Copy link
Member

MattiSG commented Jul 3, 2024

Please handle conflicts and failing tests before re-requesting review 🙂

@clementbiron clementbiron force-pushed the improve-new-type-discussion-template branch 3 times, most recently from 9eba574 to 1c77ef9 Compare July 5, 2024 07:24
.github/DISCUSSION_TEMPLATE/suggestions.yml Outdated Show resolved Hide resolved
@clementbiron clementbiron force-pushed the improve-new-type-discussion-template branch from 3abe1f7 to 1d6e093 Compare July 9, 2024 14:37
@clementbiron clementbiron merged commit af30348 into main Jul 9, 2024
2 checks passed
@clementbiron clementbiron deleted the improve-new-type-discussion-template branch July 9, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants