Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ranking Parameters Description document type #927

Merged
merged 4 commits into from
Sep 6, 2022

Conversation

MattiSG
Copy link
Member

@MattiSG MattiSG commented Sep 4, 2022

Follows https://github.com/ambanum/OpenTermsArchive/discussions/902.

This changeset also introduces the references key in the document types, to give more context and legal background to a document type.

@martinratinaud
Copy link
Member

Please do not forget to update the excel file after merge.
Also, note that contribution tool is relying on the api url to load the corresponding document types. This means that dataset will need to be republished to make the new document types available in the contribution tool.

The other possibility would be to not rely on the legacy API anymore and use the raw url from github

@Ndpnt Ndpnt force-pushed the doctype-ranking-parameters branch from 627239a to eff9863 Compare September 6, 2022 09:46
@Ndpnt Ndpnt force-pushed the doctype-ranking-parameters branch from eff9863 to 42ca69d Compare September 6, 2022 09:52
@Ndpnt Ndpnt merged commit df2cf09 into main Sep 6, 2022
@Ndpnt Ndpnt deleted the doctype-ranking-parameters branch September 6, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants