Update metadata specs #1139
Merged
Update metadata specs #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiSG
approved these changes
Feb 19, 2025
MattiSG
reviewed
Feb 22, 2025
| * totalTerms: | ||
| * type: integer | ||
| * description: Total number of terms tracked in the collection | ||
| * description: Total number of terms tracked in the collection. | ||
| * x-ota-generated: true |
There was a problem hiding this comment.
So where is that tag used to filter out the view? 🤔
There was a problem hiding this comment.
In the script that extract the specs to generate the doc in the docs repository
| * properties: | ||
| * id: | ||
| * type: string | ||
| * description: Unique identifier of the collection | ||
| * description: Unique identifier derived from name (acronyms, dash-separated). | ||
| * example: pga |
There was a problem hiding this comment.
Why do we take pga as an example, which is a third-party that we don't control, instead of demo that is here to that end?
There was a problem hiding this comment.
I've simply copied the examples from our current documentation, but you're right.
Ndpnt
force-pushed
the
update-metadata-specs
branch
from
7fc1c94 to
d1a63ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.