Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in Gitlab reporter #1135

Merged
merged 5 commits into from
Feb 17, 2025
Merged

Conversation

Phyks
Copy link
Contributor

@Phyks Phyks commented Feb 14, 2025

Hi,

There was a typo in the Gitlab reporter, therefore not being able to log errors.

The Gitlab reporter was also expecting a rigid structure (owner/repo) while Gitlab allows for more flexibility (nested subgroups). The second commit should make it possible to use such a nested structure.

@MattiSG MattiSG requested a review from Ndpnt February 17, 2025 04:19
Ndpnt
Ndpnt previously approved these changes Feb 17, 2025
@Ndpnt Ndpnt dismissed their stale review February 17, 2025 08:01

Missing changelog entry

@Ndpnt
Copy link
Member

Ndpnt commented Feb 17, 2025

Hi @Phyks,
Thanks for the fix and improvement! The code looks good to me. The only thing missing is a changelog entry. I'll take care of adding it, but for reference, you can find the related documentation here.
As for the failed lint check on the commit message, I'll take care of that as well, it looks like our action is not properly configured.

Thanks again for your contribution! :)

@Ndpnt Ndpnt force-pushed the Phyks-patch-1 branch 7 times, most recently from 9e8dc28 to 4dfdc79 Compare February 17, 2025 14:13
@Ndpnt Ndpnt merged commit 36ee6f8 into OpenTermsArchive:main Feb 17, 2025
8 checks passed
@Phyks
Copy link
Contributor Author

Phyks commented Feb 17, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants