-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure to reopen associated issue if a terms becomes inaccessible again #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5d52e1
to
56ec6a6
Compare
clementbiron
approved these changes
Mar 20, 2024
MattiSG
requested changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations for creating a sorely missing test suite for what has grown into an important part of the workflow! 👏
Here are some suggestions that are valid for the whole suite, aiming at decreasing the code size:
- Remove all white box testing (typically spy functions checking that a search was made on the list of issues, which is an implementation detail we shouldn't care about).
- Move all tested functions from
before
to theit
body. - It seems all tested cases have only 1 to 2 test functions (once suggestion 1 above is applied), mostly checking that an API call was made and sometimes checking for return value. I suggest merging these functions into 1 single test function, enabling replacing the repeated
after(nock.cleanall)
by a singleafterEach
call at the beginning of the test suite. - Use a shared fixture for issue data to avoid repeating the data setup.
Co-authored-by: Matti Schneider <matti@opentermsarchive.org>
MattiSG
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, include missing tests for the
GitHub
class in theReporter
module