-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose collection metadata API documentation with Swagger #1015
Conversation
Co-authored-by: Matti Schneider <matti@opentermsarchive.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get a blank page if I navigate to http://localhost:3000/api/v1/docs/
after having run npm install
and npm start:api
.
(also, the server does not echo the URL, which would be useful, but that's out of scope I guess) |
Hum weird 🤔. I have the same error as you with Safari but it works with Chrome and Firefox. |
Ok, I found why. It's related to the way browsers handle
|
I fix the issue on Safari and I also change the Swagger UI url to |
I tried the deployment on the experimentation server, you can check the Swagger UI here: http://54.37.5.206/api/v1/ |
Return JSON or Swagger HTML UI based on the Accept header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally:
- SwaggerUI or OpenAPI based on content type
- SwaggerUI demo
- Content load
-
/services
-
/service/Facebook
Everything works perfect!
I'm requesting changes only because of the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Perfect!!
Co-authored-by: Matti Schneider <matti@opentermsarchive.org>
No description provided.