Skip to content

Update installer ID

Update installer ID #8

Triggered via push March 2, 2024 06:27
Status Success
Total duration 5m 3s
Artifacts
Fit to window
Zoom out
Zoom in

Annotations

13 warnings
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, microsoft/setup-msbuild@v1.1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build: src/OpenSpartan.Workshop.Installer.Bundle/Bundle.wxs#L35
The ExePackage/@DetectCondition attribute or child element ArpEntry is recommended so the package is only installed when absent.
build: src/OpenSpartan.Workshop/Shared/Observable.cs#L4
Rename namespace OpenSpartan.Workshop.Shared so that it no longer conflicts with the reserved language keyword 'Shared'. Using a reserved keyword as the name of a namespace makes it harder for consumers in other languages to use the namespace. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)
build: src/OpenSpartan.Workshop/App.xaml.cs#L62
Modify 'LoadSettings' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
build: src/OpenSpartan.Workshop/Converters/MedalTypeIndexToStringConverter.cs#L10
The behavior of 'Convert.ToInt32(object)' could vary based on the current user's locale settings. Replace this call in 'MedalTypeIndexToStringConverter.Convert(object, Type, object, string)' with a call to 'Convert.ToInt32(object, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
build: src/OpenSpartan.Workshop/Converters/DoubleToPercentageStringConverter.cs#L10
The behavior of 'Convert.ToDouble(object)' could vary based on the current user's locale settings. Replace this call in 'DoubleToPercentageStringConverter.Convert(object, Type, object, string)' with a call to 'Convert.ToDouble(object, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
build: src/OpenSpartan.Workshop/Converters/MedalDifficultyToBrushConverter.cs#L11
The behavior of 'Convert.ToInt32(object)' could vary based on the current user's locale settings. Replace this call in 'MedalDifficultyToBrushConverter.Convert(object, Type, object, string)' with a call to 'Convert.ToInt32(object, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
build: src/OpenSpartan.Workshop/Data/MedalMatchesSource.cs#L32
Make 'MedalMatchesSource' sealed (a breaking change if this class has previously shipped), implement the method non-explicitly, or implement a new method that exposes the functionality of 'CommunityToolkit.Common.Collections.IIncrementalSource<OpenSpartan.Workshop.Models.MatchTableEntity>.GetPagedItemsAsync' and is visible to derived classes (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1033)
build: src/OpenSpartan.Workshop/Converters/DirectValueToPercentageStringConverter.cs#L10
The behavior of 'Convert.ToDouble(object)' could vary based on the current user's locale settings. Replace this call in 'DirectValueToPercentageStringConverter.Convert(object, Type, object, string)' with a call to 'Convert.ToDouble(object, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
build: src/OpenSpartan.Workshop/Converters/CommaAfterThousandsConverter.cs#L10
The behavior of 'string.Format(string, object)' could vary based on the current user's locale settings. Replace this call in 'CommaAfterThousandsConverter.Convert(object, Type, object, string)' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
build: src/OpenSpartan.Workshop/Converters/ComplexTimeToSimpleTimeConverter.cs#L11
The behavior of 'string.Format(string, params object[])' could vary based on the current user's locale settings. Replace this call in 'ComplexTimeToSimpleTimeConverter.Convert(object, Type, object, string)' with a call to 'string.Format(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
build: src/OpenSpartan.Workshop/Data/Extensions.cs#L45
Modify 'BootstrapTable' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)