Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wcag keyboard modal cookie settings #1245

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

BarbaraOliveira13
Copy link

@BarbaraOliveira13 BarbaraOliveira13 commented Jan 21, 2025

🎩 What?

Updated the cookie settings modal trigger in the footer by adding role="button" to the <a> tag.

🎩 Why?

Insure the <a> tag behave like a button for an interactive action that opens a modal, expected by assistive technologies:

  • Enhances accessibility by natively supporting keyboard interactions like TAB + ENTER and TAB + SPACE

📌 Related Issues

📋 Steps to Test

  1. Navigate to any page with the footer.
  2. Focus on the "Data Consent Settings" button using TAB:
  • With VoiceOver (macOS) or NVDA (Windows) activated verify that the modal opens correctly when you : Press SPACE or ENTER to open the modal.
  • Inspect and verify that the <a> tag as role="button"

📋 Subtasks

  • Added role="button" to the tag.
  • Confirmed keyboard interactions (SPACE/ENTER) work as expected.

📷 Screenshots (optional)

Additional Context

This update improves compliance with WCAG accessibility standards and enhances the user experience for those navigating via keyboard or assistive technologies.

@BarbaraOliveira13 BarbaraOliveira13 marked this pull request as ready for review January 21, 2025 14:25
@BarbaraOliveira13 BarbaraOliveira13 marked this pull request as draft January 24, 2025 09:36
@BarbaraOliveira13 BarbaraOliveira13 marked this pull request as ready for review February 3, 2025 09:36
Copy link

@AyakorK AyakorK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants