-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kurt/helios-to-aeos-stripdown #106
Open
livingkurt
wants to merge
12
commits into
master
Choose a base branch
from
kurt/helios-to-aeos-stripdown
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mode to 3, reduce number of modes to 3
definitely a lot less than I was expecting you to change, is that it? |
No not yet, I need to strip down the color selection menu to just be a classic 20 color selection menu, with no edit or delete or HSV |
- Add new color constants: RGB_AMBER and RGB_CHARTREUSE - Modify default color sets and pattern configurations - Update Makefile for macOS programmer settings
…I need to make it exit early while clearing the previous color
- Add `current_color_set` to track selected colors during color selection - Modify color selection logic to use `current_color_set` for storing and saving colors - Ensure all selected colors are saved when exiting color selection mode
- Move dimmed selection indicator to end of method - Simplify color selection state transition logic - Ensure consistent visual feedback during color selection
- Implement `setAll` method in Colorset to replace manual color setting loops - Modify color selection state to use new `setAll` method - Simplify color setting logic in Helios state handling - Improve color configuration efficiency and readability
- Modify `set` method to automatically add colors when setting an index beyond current palette size - Simplify color setting logic by removing redundant index tracking - Improve color palette management with more flexible color addition
- Remove unused pattern IDs from the enumeration - Consolidate strobe-related patterns - Reduce complexity of pattern identification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.