-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to return standard deviations for example models. #361
Conversation
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
- Coverage 84.74% 84.71% -0.04%
==========================================
Files 45 45
Lines 2957 2957
==========================================
- Hits 2506 2505 -1
- Misses 451 452 +1
Continue to review full report at Codecov.
|
b8f38a7
to
d26dfc6
Compare
Hello @tobiasraabe, do these changes work for you. I have a feeling that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Tim, thanks for this PR! It is perfect and thanks for finding the two mistakes in the former parameterization ❤️. Just one last thing. Please add this PR and your name to the release notes. Then, feel free to merge!
When you merge, please, remove the commit message in the body of the merge comment. It is useless and clutters |
Current behavior
Currently when asking for the params of an example model via
rp.get_example_model
, for example withmodel="kw_97_basis"
, only the mean estimates of the model are returned and not the estimated standard deviations.Desired behavior
An option which enables the return of the standard deviations in a bigger params data frame which has a third level on the multiindex for "mean", the classical params data frame, and "sd" the values for the standard deviations.
Solution / Implementation
See above.
Todo