Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/master branch naming #672

Merged
merged 8 commits into from
Nov 7, 2022
Merged

Build/master branch naming #672

merged 8 commits into from
Nov 7, 2022

Conversation

philipwindecker
Copy link
Contributor

@philipwindecker philipwindecker commented Oct 17, 2022

Reference to a related issue in the repository

Fixes #674

Add a description

See #674

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

Additional fix

The original pipeline currently still works with Ubuntu 18.04.
Support for this version will be removed at the end of 2022.
Therefore, a switch to Ubuntu 22.04 has been integrated as well.

Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
force a rebuild of protobuf

Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
@philipwindecker philipwindecker requested a review from pmai October 17, 2022 13:46
@philipwindecker philipwindecker added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Oct 17, 2022
@philipwindecker philipwindecker marked this pull request as ready for review October 17, 2022 13:46
@jdsika jdsika added the Quality Quality improvements. label Nov 4, 2022
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCB 2022-11-07: Can be merged as is.

@pmai pmai merged commit 225d614 into master Nov 7, 2022
philipwindecker added a commit to philipwindecker/open-simulation-interface that referenced this pull request Jan 30, 2023
Change version naming for master branch, update Ubuntu image, and add Antora generator trigger.

Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: Philip Windecker <95633467+philipwindecker@users.noreply.github.com>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality Quality improvements. ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build: Trigger generator pipeline when source content has changed
3 participants