Adapt to sqlachemy 2 #172
Draft
Adapt to sqlachemy 2 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fortinmax <maxime.fortin@rte-france.com>
Signed-off-by: fortinmax <maxime.fortin@rte-france.com>
Signed-off-by: fortinmax <maxime.fortin@rte-france.com>
Signed-off-by: fortinmax <maxime.fortin@rte-france.com>
Signed-off-by: fortinmax <maxime.fortin@rte-france.com>
Signed-off-by: fortinmax <maxime.fortin@rte-france.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| self.database = DataBase(config) | ||
|
|
||
| def test_sql_db_available(self): | ||
|
|
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
| assert self.di.check_sql_available() == True | ||
|
|
||
| def test_get_prediction_jobs(self): | ||
|
|
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
| assert isinstance(response[0], PredictionJobDataClass) | ||
|
|
||
| def test_get_pids_for_api_key(self): | ||
|
|
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
| assert isinstance(response, list) | ||
|
|
||
| def test_get_ean_for_pid(self): | ||
|
|
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
| assert isinstance(response, list) | ||
|
|
||
| def test_add_quantiles_to_prediction_jobs(self): | ||
|
|
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
| assert hasattr(response, "quantiles") | ||
|
|
||
| def test_get_systems_near_location(self): | ||
|
|
There was a problem hiding this comment.
[blackfmt] reported by reviewdog 🐶
Suggested change
Signed-off-by: fortinmax <maxime.fortin@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL Achemy 2.0 introduces a new way of sending requests.
With this PR, every Openstef-dbc SQL queries have been adapted to this new syntax.
Additionally, integration tests are proposed. for each "get" method using SQL queries.