Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallelize Travis CI #746

Merged
merged 3 commits into from
May 20, 2019
Merged

Parallelize Travis CI #746

merged 3 commits into from
May 20, 2019

Conversation

pgev
Copy link
Contributor

@pgev pgev commented May 17, 2019

No description provided.

@pgev pgev changed the title Speeds up travis by parallelizing tests [WIP] Speeds up travis by parallelizing tests May 17, 2019
@pgev pgev marked this pull request as ready for review May 17, 2019 15:18
schemar
schemar approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@schemar schemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦕

@schemar schemar changed the title [WIP] Speeds up travis by parallelizing tests Parallelize Travis CI May 17, 2019
@schemar
Copy link
Contributor

schemar commented May 17, 2019

Contracts are also compiled multiple times on each run. Maybe that can be optimized in a way.

@pgev
Copy link
Contributor Author

pgev commented May 17, 2019

Contracts are also compiled multiple times on each run. Maybe that can be optimized in a way.

@schemar Definitely. I would propose to have a warm up job and then run tests.

@schemar
Copy link
Contributor

schemar commented May 17, 2019

Is that possible? To share state of a warmup job with subsequent parallel test VMs?

@schemar
Copy link
Contributor

schemar commented May 17, 2019

I suggest we merge this as is. It already speeds up the tests to take only half the time.

deepesh-kn
deepesh-kn approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@deepesh-kn deepesh-kn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@deepesh-kn deepesh-kn merged commit e95ef90 into OpenST:develop May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schemar schemar schemar approved these changes

@deepesh-kn deepesh-kn deepesh-kn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgev @schemar @deepesh-kn