Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UUIDs iterable on utility chain #102

Merged
merged 2 commits into from
Feb 2, 2018

Conversation

jasonklein
Copy link
Contributor

@jasonklein jasonklein commented Feb 1, 2018

Makes UUIDs iterable on utility chain:

  • changes registeredTokens mapping visibility to public
  • removes registeredTokenProperties in favor of auto-generated getter, registeredTokens—platform does not appear to use registeredTokenProperties
  • inherits from the already-imported STPrimeConfig, strikes certain constants from OpenSTUtility in favor of those from STPrimeConfig, and attendant changes (the platform does use the auto-generated constant getters)
  • adds a public state var, uuids, that's a dynamic bytes32 array
  • pushes UUIDs into the uuids array in registerBrandedToken (and in the constructor of OpenSTUtility for STPrime)
  • adds function, getUuidsSize, to return size of uuids

Fixes #89

@jasonklein jasonklein force-pushed the jasonbanks/gh89/make-uuids-iterable-uc branch from 8b31551 to bcbd4f5 Compare February 2, 2018 16:23
Copy link
Contributor

@benjaminbollen benjaminbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminbollen benjaminbollen merged commit 1395b35 into develop Feb 2, 2018
@jasonklein jasonklein modified the milestones: v0.9.3, v0.9.2 Mar 27, 2018
@benjaminbollen benjaminbollen deleted the jasonbanks/gh89/make-uuids-iterable-uc branch June 4, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants