Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike driving blocks cause exception when using float type values #1544

Closed
heini208 opened this issue Aug 10, 2023 · 1 comment
Closed

Spike driving blocks cause exception when using float type values #1544

heini208 opened this issue Aug 10, 2023 · 1 comment
Assignees
@heini208

Comments

@heini208
Copy link
Contributor

Describe the bug

  • Spike driving blocks do not support floats.
  • This means that it is currently not possible to use division on a number you plan to input into any driving block

To Reproduce

  • go to spike prime
  • take any driving block
  • either ad a float value or a division
  • upload to the robot
  • see error

Expected behavior

  • floats should be cast to int when necessary

Aditional Context
image
Blocks that have at least one not working value. If the field is empty that means float caused an exception.
@heini208 heini208 self-assigned this Aug 10, 2023
@heini208 heini208 moved this from Todo to In Progress in Release 5.2.3 Aug 10, 2023
@heini208 heini208 linked a pull request Aug 10, 2023 that will close this issue
Add int cast to code generation of motor blocks for Spike #1545
Closed
bjost2s pushed a commit that referenced this issue Aug 22, 2023
@heini208 @bjost2s
Issue #1544: Add int cast to code generation of motor blocks for Spike
e780b91 
Adjust integration tests for motor block changes
@bjost2s bjost2s moved this from In Progress to To Review in Release 5.2.3 Aug 22, 2023
@bjost2s
Copy link
Contributor

bjost2s commented Aug 22, 2023

fixed

@bjost2s bjost2s closed this as completed Aug 22, 2023
@github-project-automation github-project-automation bot moved this from To Review to Done in Release 5.2.3 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heini208 heini208

Labels
None yet
Projects
No open projects
Release 5.2.3
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add int cast to code generation of motor blocks for Spike OpenRoberta/openroberta-lab
2 participants
@bjost2s @heini208