Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program Export does not work #1279

Closed
Thorlogy opened this issue Apr 19, 2022 · 7 comments
Closed

Program Export does not work #1279

Thorlogy opened this issue Apr 19, 2022 · 7 comments
Assignees
Labels

Comments

@Thorlogy
Copy link

With Safari on MacBook MOS Monterey Version12.3.1 the export of a program does not work

@joernalraun
Copy link

This is the same on any MacOS when using Safari.

@bjost2s
Copy link
Contributor

bjost2s commented Apr 25, 2022

What exactly happens? What are the error messages if any, or do you see something in the log?

@Thorlogy
Copy link
Author

Nothing happens, no error messages nothing.

Log:
image

@RaghuvirShirodkar
Copy link
Member

Program export (and import) works on the MacBook that I have here...

Tested on:

MacOS Monterey v12.1

Browsers:

Safari v15.2
Firefox v91.5.0esr

Tested on lab as well as test.

@joernalraun
Copy link

@RaghuvirShirodkar This has been an issue since a couple of years, but only on Safari...

@RaghuvirShirodkar RaghuvirShirodkar self-assigned this Apr 26, 2022
@RaghuvirShirodkar
Copy link
Member

I think I found the bug that causes this issue and how to reproduce it.

Probable cause

download attribute for a tag doesn't seem to work for some newer Safari versions.

Steps to reproduce

  1. Go to lab.open-roberta.org.
  2. Create a sample program for any robot.
  3. Click on the edit menu -> export program.
  4. Observe that nothing is downloaded.

Since I was exporting the program through keyboard shortcuts (Ctrl + E), it was working for me. However, when I try to export the program through the menu, nothing is downloaded.

RaghuvirShirodkar added a commit that referenced this issue Apr 26, 2022
- add timeout for click event.
- fix missing generated js code in staticResources.
- fix formatting errors.
@Thorlogy
Copy link
Author

Thorlogy commented May 4, 2022

Program Export with Safari works now

@bjost2s bjost2s closed this as completed May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants