Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor NXT Visitor/Worker #1271

Closed
6 tasks done
RaghuvirShirodkar opened this issue Apr 12, 2022 · 0 comments · Fixed by #1280
Closed
6 tasks done

Refactor NXT Visitor/Worker #1271

RaghuvirShirodkar opened this issue Apr 12, 2022 · 0 comments · Fixed by #1280
Assignees
@RaghuvirShirodkar
Labels
resolved

Comments

@RaghuvirShirodkar
Copy link
Member

RaghuvirShirodkar commented Apr 12, 2022 •
edited
Loading

Refactor NXT to adhere to the structure laid out for other robots.

TASKs

  • Check current implementation.
  • Refactor relevant NxtUsedHardwareCollector*, NxtUsedMethodCollector* visitor/worker into NxtValidatorAndCollector* visitor/worker.
  • Refactor relevant visitor/worker into NxtSimValidatorAndCollector* visitor/worker.
  • Remove old (separately used) nxt visitors/workers.

TESTs

  • Check changes by running local server.
  • Check changes by running integration tests.
@RaghuvirShirodkar RaghuvirShirodkar mentioned this issue Apr 12, 2022
Closed
20 tasks
@RaghuvirShirodkar RaghuvirShirodkar changed the title NXT Refactor NXT Visitor/Worker Structure Apr 12, 2022
@RaghuvirShirodkar RaghuvirShirodkar self-assigned this Apr 12, 2022
@RaghuvirShirodkar RaghuvirShirodkar changed the title Refactor NXT Visitor/Worker Structure Refactor NXT Visitor/Worker Apr 12, 2022
RaghuvirShirodkar added a commit that referenced this issue Apr 21, 2022
@RaghuvirShirodkar
Issue #1271: refactor NXT visitor/worker structure:
5063aa5 
- add NXTValidatorAndCollector* visitor/worker.
- add NXTSimValidatorAndCollector* visitor/worker.
- remove UsedHardware* visitor/worker.
- remove UsedMethod* visitor/worker.
- restructure INxtVisitor and NxtMethods.
- fix tests.

add
RaghuvirShirodkar added a commit that referenced this issue Apr 21, 2022
@RaghuvirShirodkar
Issue #1271: refactor NXT visitor/worker structure:
6818e0f 
- add NXTValidatorAndCollector* visitor/worker.
- add NXTSimValidatorAndCollector* visitor/worker.
- remove UsedHardware* visitor/worker.
- remove UsedMethod* visitor/worker.
- restructure INxtVisitor and NxtMethods.
- fix tests.
@RaghuvirShirodkar RaghuvirShirodkar mentioned this issue Apr 21, 2022
Merged
7 tasks
RaghuvirShirodkar added a commit that referenced this issue Apr 21, 2022
@RaghuvirShirodkar
Issue #1271: refactor NXT visitor/worker structure:
2ec0eef 
- add NXTValidatorAndCollector* visitor/worker.
- add NXTSimValidatorAndCollector* visitor/worker.
- remove UsedHardware* visitor/worker.
- remove UsedMethod* visitor/worker.
- restructure INxtVisitor and NxtMethods.
- fix tests.
bjost2s pushed a commit that referenced this issue Apr 25, 2022
@RaghuvirShirodkar @bjost2s
Issue #1271: refactor NXT visitor/worker structure:
66473d4 
- add NXTValidatorAndCollector* visitor/worker.
- add NXTSimValidatorAndCollector* visitor/worker.
- remove UsedHardware* visitor/worker.
- remove UsedMethod* visitor/worker.
- restructure INxtVisitor and NxtMethods.
- fix tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaghuvirShirodkar RaghuvirShirodkar

Labels
resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #1271: refactor NXT visitor/worker structure. OpenRoberta/openroberta-lab
2 participants
@bjost2s @RaghuvirShirodkar