Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Bot'n Roll Visitor/Worker #1263

Closed
5 tasks done
RaghuvirShirodkar opened this issue Apr 6, 2022 · 0 comments
Closed
5 tasks done

Refactor Bot'n Roll Visitor/Worker #1263

RaghuvirShirodkar opened this issue Apr 6, 2022 · 0 comments
Assignees
@RaghuvirShirodkar
Labels
resolved

Comments

@RaghuvirShirodkar
Copy link
Member

RaghuvirShirodkar commented Apr 6, 2022 •
edited
Loading

Refactor Bot'n Roll to adhere to the structure laid out for other Arduino robots.
Related issue: #1163

TASKs

  • Check current implementation.
  • Refactor relevant BotnrollUsedHardwareCollector*, BotnrollUsedMethodCollector* visitor/worker into BotnrollValidatorAndCollector* visitor/worker.
  • Remove old (separately used) bot'n roll visitors/workers.

TESTs

  • Check changes by running local server.
  • Check changes by running integration tests.
@RaghuvirShirodkar RaghuvirShirodkar mentioned this issue Apr 6, 2022
Closed
20 tasks
@RaghuvirShirodkar RaghuvirShirodkar changed the title Bot'n Roll Refactor Bot'n Roll Visitor/Worker Apr 6, 2022
@RaghuvirShirodkar RaghuvirShirodkar self-assigned this Apr 6, 2022
RaghuvirShirodkar added a commit that referenced this issue Apr 20, 2022
@RaghuvirShirodkar
Issue #1263: refactor Bot'n Roll:
b82301b 
  - add BotnrollValidatorAndCollector* visitor/worker.
  - update relevant plugin properties.
  - remove unused visitors/workers.
@bjost2s bjost2s added the viewed label May 2, 2022
@bjost2s bjost2s closed this as completed May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaghuvirShirodkar RaghuvirShirodkar

Labels
resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bjost2s @RaghuvirShirodkar