Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor NIBO {BOB3, ROB3RTA} Visitor/Worker #1258

Closed
5 tasks done
RaghuvirShirodkar opened this issue Apr 4, 2022 · 0 comments · Fixed by #1264
Closed
5 tasks done

Refactor NIBO {BOB3, ROB3RTA} Visitor/Worker #1258

RaghuvirShirodkar opened this issue Apr 4, 2022 · 0 comments · Fixed by #1264
Assignees
@RaghuvirShirodkar
Labels
resolved

Comments

@RaghuvirShirodkar
Copy link
Member

RaghuvirShirodkar commented Apr 4, 2022 •
edited
Loading

Refactor NIBO robots (BOB3, ROB3RTA) to adhere to the structure laid out for other Arduino robots.
Related issue: #1163

TASKs

  • Check current implementation
  • Refactor relevant Bob3UsedHardwareCollector*, Bob3UsedMethodCollector* visitor/worker into NIBOValidatorAndCollector* visitor/worker.
  • Remove old (separately used) bob3 visitors/workers.

TESTs

  • Check changes by running local server.
  • Check changes by running integration tests.
@RaghuvirShirodkar RaghuvirShirodkar mentioned this issue Apr 4, 2022
Closed
20 tasks
@RaghuvirShirodkar RaghuvirShirodkar changed the title BOB3 Refactor NIBO {BOB3, ROB3RTA} Visitor/Worker Apr 4, 2022
@RaghuvirShirodkar RaghuvirShirodkar self-assigned this Apr 4, 2022
RaghuvirShirodkar added a commit that referenced this issue Apr 6, 2022
@RaghuvirShirodkar
Issue #1258: refactor NIBO robots' (BOB3 and ROB3RTA) visitor/worker …
bd7107a 
…structure:

  - add NIBOValidatorAndCollectorVisitor and NIBOValidatorAndCollectorWorker for validation.
  - update bob3 and rob3rta .properties files.
  - remove old (separately used) bob3 visitors/workers.
  - add *ValidatorAndCollector* visitors/workers for bob3/rob3rta.
  - update sensor-reads.xml for bob3.
@RaghuvirShirodkar RaghuvirShirodkar mentioned this issue Apr 6, 2022
Merged
7 tasks
bjost2s pushed a commit that referenced this issue Apr 7, 2022
@RaghuvirShirodkar @bjost2s
Issue #1258: refactor NIBO robots' (BOB3 and ROB3RTA) visitor/worker …
7091450 
…structure:

  - add NIBOValidatorAndCollectorVisitor and NIBOValidatorAndCollectorWorker for validation.
  - update bob3 and rob3rta .properties files.
  - remove old (separately used) bob3 visitors/workers.
  - add *ValidatorAndCollector* visitors/workers for bob3/rob3rta.
  - update sensor-reads.xml for bob3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaghuvirShirodkar RaghuvirShirodkar

Labels
resolved
Projects
None yet
Milestone
No milestone
2 participants
@bjost2s @RaghuvirShirodkar