-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Docusaurus 3.0 Completed With Checks #279
Conversation
✅ Deploy Preview for openrefine-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The error occurring due to node node v16.20.2 (npm v8.19.4), but we have to update the node engine to "node": ">=18.0", do we require to do this in code, or anyone have to setup this in Netlify side? |
Here is it not accepting my PR, it due to Node engine 18, so I deployed it manually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aakash-a-dev, thank you so much for having a go at this! Looking at the "Files changed" tab of this pull request, I see quite some Docusaurus example files which you seem to have committed into your pull request. Needless to say, I think those should not be included. The rest of the changes look promising, I would review them once you have removed those example files.
@wetneb Thank you for your comment, I went through it. Truly sorry for this. I rectified the example data files uploaded. |
I also corrected the exporting.md when I went through the file changes few lines were unnecessary. Thank you for let me give my attention towards here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
I have updated Netlify to use Node.js 20. Next time you make changes to this PR (for instance, solving the merge conflicts with yarn.lock), the site should compile properly. |
[cause]: Error: Failed to compile due to Webpack errors. Getting this error while building it in netlify. Any way I can rectify it. |
I would upgrade to 3.1 then in this case? ... that way we can take advantage of the main thing folks are complaining about just like us... "broken anchors". They added a new checker for that in v3.1
but not sure on do/dont on the syntax changes ? dunno, but @slorber mentioned custom header ids need a special syntax for MDX v2 support facebook/docusaurus#3321 (comment) |
Now It passed every case!. It worked this time found out the issue. |
@thadguidry I upgraded this to 3.1 only, when I went through documentation that's the best thing I thought to do. So the current code is for 3.1 only. |
@aakash-a-dev but did you read the comment that l linked to? It specifically addresses @ostephens concern about the header ids, I think? But it looks like their official docs don't mention those things? Maybe we should ask them?
|
@thadguidry This is the approach that @aakash-a-dev has taken so all good I think, although feedback to the Docusaurus documentation would make sense |
I made it again /{#headingId} to {#headingId} I did it to rectify an issue but comes to know that the issue was taking place due to something else and I rectified it and mentioned in above comment. I guess we don't have to worry about escape ids now. |
Hello I didn't heard from a long time on this PR, so just thought to put a follow up comment. If anywhere you think I require to make modification I am happy to do that. Thank you. |
Could you fix the merge conflict with |
Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu>
Resolved Yarn.lock conflict @wetneb |
Pardon! I actually made the changes you asked and also worked on conflict error of yarn.lock file and every thing get done, is there any further changes I require to make? Will happy to that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Here, I completed the checkmark and also updated it to Docusaurus 3.0 although there is also 3.1.0 but still I updated to 3.0 for now.
Before checklist till making it Docusaurus 3.0:
After checklist till making it Docusaurus 3.0:
Hoping for a positive feedback and positive review for this PR.
Fix: #274