Make sure we don't add extra copies of printers.

OpenPrinting · Dec 18, 2024 · b0d1f90 · b0d1f90
1 parent 0a28913
commit b0d1f90
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -11,6 +11,7 @@ libcups v3.0rc4 (YYYY-MM-DD)
   `--client-name` options.
 - Updated `cupsOAuthGetMetadata` to support Microsoft Azure/Entra OAuth
   servers.
+- Fixed a duplicate printer reporting bug in `cupsGetDests`.
 
 
 libcups v3.0rc3 (2024-10-22)

diff --git a/cups/dest.c b/cups/dest.c
@@ -3050,9 +3050,9 @@ cups_get_cb(_cups_getdata_t *data,      // I - Data from cupsGetDests
     // Remove destination from array...
     data->num_dests = cupsRemoveDest(dest->name, dest->instance, data->num_dests, &data->dests);
   }
-  else
+  else if (!cupsGetDest(dest->name, dest->instance, data->num_dests, data->dests))
   {
-    // Add destination to array...
+    // Add destination to array if not already present...
     data->num_dests = cupsCopyDest(dest, data->num_dests, &data->dests);
   }