Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove bloat from merge group #648

Open
kilpatty opened this issue Jan 23, 2024 · 1 comment
Open

ci: remove bloat from merge group #648

kilpatty opened this issue Jan 23, 2024 · 1 comment

Comments

@kilpatty
Copy link
Contributor

Our cargo bloat action does not work on "merge_group" actions I believe, it also hasn't been updated since 2021 - let's look at some other options, or run one ourselves.
kilpatty added a commit that referenced this issue Jan 25, 2024
@kilpatty
ci: don't run bloat on scheduled runs
47061b2 
Addresses #648 - Bloat doesn't work when there is no ref to compare. There is probably a better way to fix this, but for now let's see how this works. 

This will likely fail if there is a manually triggered re-run, because again, there is no ref to compare to.

Signed-off-by: Sean Kilgarriff <seanpkilgarriff@gmail.com>
@kilpatty
Copy link
Contributor Author

I believe that I was wrong in my previous diagnosis - bloat is failing not on "merge_group" runs, but rather on scheduled runs. I have implemeneted a quick fix for that, but I do believe there are other scenarios where this could fail.

Permanent solutions:

  1. Move Bloat to it's own workflow file
  2. Figure out an "if" statement that controls for whether we are comparing any branches. I believe there is one GITHUB_BASE_REF which will be empty if there is no base ref, so that is something e could try to implement with

@kilpatty kilpatty mentioned this issue Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kilpatty