Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equals hash code #83

Closed
wants to merge 2 commits into from
Closed

Equals hash code #83

wants to merge 2 commits into from

Conversation

Eulbobo
Copy link

@Eulbobo Eulbobo commented Apr 27, 2016

Adding equals and hashcode tests and rules

JulienBO added 2 commits April 27, 2016 13:28
Checks that both methods are either defined or absent
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 93.404% when pulling 9d90555 on Eulbobo:equals-hashCode into 8f56182 on oshoukry:master.

oshoukry added a commit that referenced this pull request May 30, 2017
…ismatch implementation, for example one implemented without the other. So either both must exist or both missing.
@oshoukry
Copy link
Member

An excellent idea, I've implemented the Rule similar to what you had in the pull request, however, the tester for equals and hashCode won't be in just yet as I feel the library solution for this is to utilize BusinessKey and dispatch the equals and hashCode to BusinessIdentity (see https://github.com/oshoukry/openpojo/wiki/Tutorial-5.-Identity-Management)

@oshoukry oshoukry closed this May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants