Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetterMustExist Not Ignoring Synthetic Fields #139

Closed
scampbell5 opened this issue Mar 17, 2021 · 3 comments
Closed

SetterMustExist Not Ignoring Synthetic Fields #139

scampbell5 opened this issue Mar 17, 2021 · 3 comments

Comments

@scampbell5
Copy link

scampbell5 commented Mar 17, 2021

Hello,

We use this library alongside of pitest for mutation checks. Recently we have upgraded to pitest >= 1.6.2 which now currently fails to run mutation coverage because when pitest injects their private field probes into the classes that openpojo is testing against, it's causing it to fail due to it not finding a setter for these synthetic fields. I opened an issue in the pitest plugin here: hcoles/pitest#873. Their suggestion was to have openpojo ignore synthetic fields. I noticed for the Getter rule, that was already in place: https://github.com/OpenPojo/openpojo/releases/tag/openpojo-0.8.6, but not the for SetterMustExistRule. I created a PR to fix this issue: #138

@mustaphazorgati
Copy link

@OrDTesters, @oshoukry,

can you please have a look at this? I think this is a very quick one :)

oshoukry pushed a commit that referenced this issue May 16, 2021
oshoukry added a commit that referenced this issue May 17, 2021
@oshoukry
Copy link
Member

issue fixed and released see latest release.

@mustaphazorgati
Copy link

👏 Thank you very much. Works like a charm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants