Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NO examples to be true to rule UBL-CR-679 #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eivinhb
Copy link

@eivinhb eivinhb commented Jan 18, 2021

Rule UBL-CR-679 states:
not(//cac:ClassifiedTaxCategory/cbc:ID/@schemeID)

I find it somewhat confusing when the national examples warns of incorrect content with the rules that apply and are made mandatory. I guess this in practice has no implications other than confusion and distractions.

@midran
Copy link
Contributor

midran commented Apr 25, 2022

@eivinhb , is this pull request still relevant. It seemst to have been passed over in Peppol development.

@eivinhb
Copy link
Author

eivinhb commented Apr 25, 2022

https://docs.peppol.eu/poacc/billing/3.0/rules/UBL-CR-679/ <- This has not been changed, so I guess this still apply.
It is only the example that is wrong. If you try and validate the example it fails on this particular rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants