-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable SSR #2017
Enable SSR #2017
Conversation
Configures tsconfig for project wide builds.
This requires a refactor to be type safe but it works well enough for now.
This fixes the DropdownButton component and drops another dep on react-bootstrap.
true generates sourcemaps that most tools can find automatically. External just generates the map.
Looks like CI just needs to be updated for tests, they should pass locally. I'm working on the CI issue. |
Switch to fork of bids-validator for one release. This fork fixes various build issues with mixing cjs/esm modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the metadata from the upload form isn't being saved, but otherwise this looks great.
Tested:
- Yarn tests passing
- Front page:
- Queried data
- Login
- Logout
- Admin nav item
- Support nav item and its function
- Responsive layout
- Admin page
- My Dashboard (my and saved datasets) & Public Dashboard
- Has expected datasets
- Search
- Filters
- Sorters
- Responsive layout
- Upload & Download
- validator runs properly
- metadata is saved (issue)
- defacing/authorization is required
- Dataset Page
- Has expected:
- data
- snapshots
- git hash
- validator warnings
- Readme and description edits
- File and directory deletions
- File and directory uploads
- File viewers (text, json, nifti)
- File updates
- Edits to draft are validated immediately
- Snapshots
- Draft head reset
- Publish dataset
- Remote reexports
- Adds metadata
- Comments (add, reply, delete)
- Has expected:
Looks like the metadata issue is older than this branch but I went ahead and fixed it. |
Just a snapshot needs updating, but otherwise good to go. |
Fix admin page regression from #2017
fix(cli): Incorrect auth headers and stream type changes from #2017
This supersedes #1997 and includes some fixes from the review of that.
New major changes:
This requires using the dev branch of bids-validator and merging https://github.com/bids-standard/bids-validator/pull/1238
It also depends on a change in Vite to support classic web workers. We need classic workers for Firefox support for bids-validator. This requires some workarounds that I'll break out from this PR
One final note, for testing with SSR try disabling JavaScript. You should be able to click anything which is a real href and have the routes load. Some are visually compromised without JavaScript (the dashboard page) but should work well enough for search indexing.