Simplify Inference #2429
Closed
Simplify Inference #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince62s
reviewed
Jul 3, 2023
l-k-11235
force-pushed
the
simplify-inference
branch
from
3ea531d
to
6c72154
Compare
|
I should add an example for the inference from a list of strings here https://opennmt.net/OpenNMT-py/quickstart.html#step-3-translate |
|
also remove the infer_opt changes in translator.py |
vince62s
reviewed
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to simplify inference by adding a
translate_stringsmethod to be applied to a list of raw strings.It is used and it has been tested in
eval_llm/MMLU/run_mmlu_opennmt.pyand indocs/source/examples/replicate_vicuna/chatbot.py.