-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.9 #248
3.9 #248
Conversation
Ready to merge. (Really right now) |
Nice!! Thank you for fixing the stuff I pointed out. It's now much better overall :) |
I really like how the changes are looking so far! Here's a few additional improvements I'd suggest:
I'd really like to ship a dark version of the Fluent theme as well. Let me know if you'd be able to work on it; otherwise, I'll give it a shot. :) |
It's better to test working and useable before committing to avoid conflicts |
About the url text, the Fluent design format shows that when hovering on URL or hyperlinks, the text becomes gray. |
merged my experimental branch into this because why not and also no more conflicts |
Ctrl + P --> Preferences F7 --> Cycle through the FPS options and display a popup
Alt + Enter to fullscreen like most games |
Leftover line after interactive rebase to remove Realtime Blur extension files
30e1aac
to
c287a01
Compare
Since Realtime Blur, the extension used for the Acrylic and Mica effects, is a paid extension, it wouldn't be ethical to publish its source code on the repository, as this would enable anyone who cloned the project to obtain the extension for free. In order to remove its source code from the repository, I did an interactive rebase editing commit 89f3da4 (new hash) to remove the affected files. During development, these files were added to To allow the project to work even with the extension files missing, commit 634b383 introduced a script, This way, anyone who clones the repository will be able to run the program as normal. However, in order for the blur effect to work, a copy of the extension must be placed in the correct spot. For production releases, whoever builds the version must make sure to load the files correctly (this will likely be me, so consider this a note to self :D). For record, a list of the affected files is kept below: Affected files:
One consequence of rebasing is that it rewrites the branch's history, which requires a force push. So if anyone besides me and @chenxi050402 has based work off this branch, make sure to clone it again! With that, this PR should be (finally) ready to merge into the project! 🥳 |
a97ef15
to
5382e4f
Compare
That fix somehow got lost in the merge conflicts.
- Scrolling while pressing down the mouse wheel is uncommon and sort of difficult. - Ctrl + Scroll wheel is a widely used shortcut for zooming in/out, so many users won't need adaptation. - If a user needs to scroll the song while selecting notes, they may use the scrollbar or release Ctrl temporarily. Also, it seems more appropriate to drag a selection box instead of selecting individual notes if notes outside the viewport must be selected.
Fixes issue #214.
Fixes issue #198 (sort of).