Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve server creation #539

Merged
merged 1 commit into from
Feb 3, 2025
Merged

improve server creation #539

merged 1 commit into from
Feb 3, 2025

Conversation

eelcovdw
Copy link
Contributor

@eelcovdw eelcovdw commented Feb 3, 2025 •
edited
Loading

Description

Serverside changes required to implement in-memory stack

  • move all server endpoints to router
  • factory method for server
  • better settings injection
  • some minor clientside changes, they are not use currently but will be for an in-memory server (with TestClient)

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@eelcovdw eelcovdw merged commit 91249d4 into main Feb 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koenvanderveen koenvanderveen koenvanderveen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eelcovdw @koenvanderveen